Thursday, 15 November 2012

WebVTT Syntax Test Review

I'm going over all the syntax tests for WebVTT. These tests can be found in the following two locations.
Main repo: https://github.com/humphd/webvtt/tree/seneca/test/spec
My fork: https://github.com/KyleBarnhart/webvtt/tree/seneca/test/spec

I am not judging if the tests actually pass or not, but rather should they pass. I am currently assuming that tests in the directory "good" and "known-bad" pass, and that tests in "bad" and "known-good" fail. I will modify the files to keep the intent. If I cannot do that I will move. them around thus knowing. For example a test in "good" that should not pass will be moved to "known-bad". Also I will only list changes.

I've made a change to the WebVTT syntax post. Cue start times may be equal to previous start times, but not less than.

I will submit a pull request after I have tested the changes,

Good

  • tc_1001_WEBVTT-no-BOM.test
    • Added one more line terminator. Two or more line terminators are require after WEBVTT.
  • tc_1002_WEBVTT-with-BOM.test
    • Added two line terminator. Two or more line terminators are require after WEBVTT.
  • tc_1003_WEBVTT-head.test
    • Added two line terminator. Two or more line terminators are require after WEBVTT.
  • tc_1004_WEBVTT-space.test
    • Added one more line terminator. Two or more line terminators are require after WEBVTT.
  • tc_1005_WEBVTT-tab.test
    • Added two line terminator. Two or more line terminators are require after WEBVTT.
  • tc_1007_space-text.test
    • Added one more line terminator. Two or more line terminators are require after WEBVTT.
  • tc_1008_tab-Text.test
    • Added one more line terminator. Two or more line terminators are require after WEBVTT.

Known-Good

  • tc000-sample_test.test and tc5300-embedded_voice.test are identical
    • remove tc000-sample_test.test since the other fits better with the naming scheme

Bad

  • tc3100-cuetimings_separator_left_bad.test
    • WEBVTT string is malformed so not checking timestamp 
    • changed "WWEBVTT" to "WEBVTT"
  • tc3102-cuetimings_separator_left_bad.test
    • WEBVTT string is malformed so not checking timestamp 
    • changed "WWEBVTT" to "WEBVTT"
  • tc3103-cuetimings_separator_leftright_bad.test
    • WEBVTT string is malformed so not checking timestamp 
    • changed "WWEBVTT" to "WEBVTT"
  • tc3104-cuetimings_separator_malformed_bad.test
    • WEBVTT string is malformed so not checking timestamp 
    • changed "WWEBVTT" to "WEBVTT"
  • tc3105-cuetimings_separator_missing_bad.test
    • WEBVTT string is malformed so not checking timestamp 
    • changed "WWEBVTT" to "WEBVTT"
  • tc3106-cuetimings_separator_right_bad.test
    • WEBVTT string is malformed so not checking timestamp 
    • changed "WWEBVTT" to "WEBVTT"

Known-Bad

  • Nothing wrong

No comments:

Post a Comment